tweaks(yamux): Improvements to reducer #1085
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tizoc
force-pushed
the
tweaks/yamux
branch
3 times, most recently
from
8b6ee76 to
30e5b3a
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR implements several improvements to the Yamux reducer handling and stream state management. Key changes include:
- Adjusting window sizing constants and modifying the window update logic.
- Introducing multiple new helper functions in the YamuxStreamState to manage remote/local windows and frame queuing.
- Updating reducer logic to handle new Yamux frame types and improving error dispatching.
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| p2p/src/network/yamux/p2p_network_yamux_state.rs | Adjusted window constants and added helper methods for frame handling and window updates. |
| p2p/src/network/yamux/p2p_network_yamux_reducer.rs | Refactored frame dispatching logic with new action variants and streamlined error handling. |
| p2p/src/network/yamux/p2p_network_yamux_actions.rs | Added new Yamux action variants to support refined frame processing. |
| p2p/src/network/yamux/mod.rs | Updated exports to expose the new YamuxStreamState. |
| p2p/src/network/scheduler/p2p_network_scheduler_state.rs | Exposed additional utility methods for stream retrieval and incoming stream counting. |
| node/src/action_kind.rs | Expanded action kind enumeration and updated the count accordingly. |
Comments suppressed due to low confidence (2)
p2p/src/network/yamux/p2p_network_yamux_state.rs:10
- The MAX_WINDOW_SIZE constant now equals INITIAL_RECV_BUFFER_CAPACITY (256kb), which contradicts the previous comment indicating 16mb. If this change is intentional, please update the comment to prevent confusion.
pub const MAX_WINDOW_SIZE: u32 = INITIAL_RECV_BUFFER_CAPACITY as u32;
p2p/src/network/yamux/p2p_network_yamux_reducer.rs:324
- [nitpick] Consider using a more descriptive error message in the expect() call to clearly document why an accepted frame is mandatory.
frame = accepted.expect("frame should be accepted or error should be returned");
Comment on lines
+245
to
+246
| let frame = yamux_state.incoming.pop_front().unwrap(); // Cannot fail | ||
|
|
There was a problem hiding this comment.
[nitpick] Using unwrap() here assumes the incoming frame queue is never empty; consider using expect() with a descriptive error message to aid future debugging if the invariant is broken.
Suggested change
| let frame = yamux_state.incoming.pop_front().unwrap(); // Cannot fail | |
| let frame = yamux_state.incoming.pop_front().expect("Expected a frame in the incoming queue"); // Cannot fail |
Copilot uses AI. Check for mistakes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.